This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($animate): document the 3rd party framework compatibility issues #ngEurope #9722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -219,6 +219,12 @@ | |||
| * Also, try not to mix the two class-based animation flavors together since the CSS code may become | |||
| * overly complex. | |||
| * | |||
| * <div class="alert alert-warning"> | |||
| * **Note:** Some third-party frameworks place animation duration defaults across many element or className selectors in order to make their code small and reuseable. | |||
| * This can lead to issues with ngAnimate, which is expecting actual animations on theses elements and has to wait for their completion. | |||
There was a problem hiding this comment.
which is expecting actual animations on these elements
|
@rodyhaddad fixed the typo, thanks. |
|
Can you add an example about how you'd do this in css? (or the side-effects of this on your css) |
|
I merged this with a few changes. Code blocks in div blocks don't format very well. So I moved it into a section of its own. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8569, I hope the wording is both correct and clear enough.